summaryrefslogtreecommitdiff
path: root/transport-helper.c
diff options
context:
space:
mode:
authorFelipe Contreras <felipe.contreras@gmail.com>2013-04-18 04:14:31 (GMT)
committerJunio C Hamano <gitster@pobox.com>2013-04-18 06:27:03 (GMT)
commita93b4a09acfed0e2a006770d0196c74968e65c25 (patch)
tree27800b715303923bc1323ba1836d0bf27d0a6e97 /transport-helper.c
parent21610d820b97583a8f4e3e7f4a48716c8e32fd92 (diff)
downloadgit-a93b4a09acfed0e2a006770d0196c74968e65c25.zip
git-a93b4a09acfed0e2a006770d0196c74968e65c25.tar.gz
git-a93b4a09acfed0e2a006770d0196c74968e65c25.tar.bz2
transport-helper: warn when refspec is not used
For the modes that need it. In the future we should probably error out, instead of providing half-assed support. The reason we want to do this is because if it's not present, the remote helper might be updating refs/heads/*, or refs/remotes/origin/*, directly, and in the process fetch will get confused trying to update refs that are already updated, or older than what they should be. We shouldn't be messing with the rest of git. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'transport-helper.c')
-rw-r--r--transport-helper.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/transport-helper.c b/transport-helper.c
index 98ef8f6..2452b3b 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -215,6 +215,8 @@ static struct child_process *get_helper(struct transport *transport)
free((char *)refspecs[i]);
}
free(refspecs);
+ } else if (data->import || data->bidi_import || data->export) {
+ warning("This remote helper should implement refspec capability.");
}
strbuf_release(&buf);
if (debug)