diff options
| author | Felipe Contreras <felipe.contreras@gmail.com> | 2013-04-18 04:14:30 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2013-04-18 06:27:03 (GMT) |
| commit | 21610d820b97583a8f4e3e7f4a48716c8e32fd92 (patch) | |
| tree | ff5afc835ea273a105a2ed0b7514b2fc5c30ff0e /transport-helper.c | |
| parent | bb0a5cc9dc574e1dda4ee6bcb1e0f166d29dcd65 (diff) | |
| download | git-21610d820b97583a8f4e3e7f4a48716c8e32fd92.zip git-21610d820b97583a8f4e3e7f4a48716c8e32fd92.tar.gz git-21610d820b97583a8f4e3e7f4a48716c8e32fd92.tar.bz2 | |
transport-helper: clarify pushing without refspecs
This has never worked, since it's inception the code simply skips all
the refs, essentially telling fast-export to do nothing.
Let's at least tell the user what's going on.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'transport-helper.c')
| -rw-r--r-- | transport-helper.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/transport-helper.c b/transport-helper.c index 018513b..98ef8f6 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -785,6 +785,9 @@ static int push_refs_with_export(struct transport *transport, struct string_list revlist_args = STRING_LIST_INIT_NODUP; struct strbuf buf = STRBUF_INIT; + if (!data->refspecs) + die("remote-helper doesn't support push; refspec needed"); + helper = get_helper(transport); write_constant(helper->in, "export\n"); @@ -795,8 +798,6 @@ static int push_refs_with_export(struct transport *transport, char *private; unsigned char sha1[20]; - if (!data->refspecs) - continue; private = apply_refspecs(data->refspecs, data->refspec_nr, ref->name); if (private && !get_sha1(private, sha1)) { strbuf_addf(&buf, "^%s", private); |