summaryrefslogtreecommitdiff
path: root/upload-pack.c
diff options
context:
space:
mode:
authorChristian Couder <christian.couder@gmail.com>2020-06-04 17:54:49 (GMT)
committerJunio C Hamano <gitster@pobox.com>2020-06-04 17:58:27 (GMT)
commite3835cd4bc6d727bf16a42229c0ca757c088e9d3 (patch)
tree068202822c9041d48b480b954ab343165586114c /upload-pack.c
parentd1d7a9452629a6caa26e80bd6ca69366ff65dd89 (diff)
downloadgit-e3835cd4bc6d727bf16a42229c0ca757c088e9d3.zip
git-e3835cd4bc6d727bf16a42229c0ca757c088e9d3.tar.gz
git-e3835cd4bc6d727bf16a42229c0ca757c088e9d3.tar.bz2
upload-pack: move allow_sideband_all to upload_pack_data
As we cleanup 'upload-pack.c' by using 'struct upload_pack_data' more thoroughly, let's move the 'allow_sideband_all' static variable into this struct. It is used only by protocol v2 code. Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Acked-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'upload-pack.c')
-rw-r--r--upload-pack.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/upload-pack.c b/upload-pack.c
index 0d75745..78b10a8 100644
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -55,8 +55,6 @@ static int shallow_nr;
static struct object_array extra_edge_obj;
static const char *pack_objects_hook;
-static int allow_sideband_all;
-
/*
* Please annotate, and if possible group together, fields used only
* for protocol v0 or only for protocol v2.
@@ -103,6 +101,7 @@ struct upload_pack_data {
unsigned done : 1; /* v2 only */
unsigned allow_ref_in_want : 1; /* v2 only */
+ unsigned allow_sideband_all : 1; /* v2 only */
};
static void upload_pack_data_init(struct upload_pack_data *data)
@@ -1146,7 +1145,7 @@ static int upload_pack_config(const char *var, const char *value, void *cb_data)
} else if (!strcmp("uploadpack.allowrefinwant", var)) {
data->allow_ref_in_want = git_config_bool(var, value);
} else if (!strcmp("uploadpack.allowsidebandall", var)) {
- allow_sideband_all = git_config_bool(var, value);
+ data->allow_sideband_all = git_config_bool(var, value);
} else if (!strcmp("core.precomposeunicode", var)) {
precomposed_unicode = git_config_bool(var, value);
}
@@ -1341,7 +1340,7 @@ static void process_args(struct packet_reader *request,
}
if ((git_env_bool("GIT_TEST_SIDEBAND_ALL", 0) ||
- allow_sideband_all) &&
+ data->allow_sideband_all) &&
!strcmp(arg, "sideband-all")) {
data->writer.use_sideband = 1;
continue;