diff options
| author | Nguyễn Thái Ngọc Duy <pclouds@gmail.com> | 2011-12-12 11:20:32 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2011-12-13 17:39:46 (GMT) |
| commit | 8cad4744ee37ebec1d9491a1381ec1771a1ba795 (patch) | |
| tree | 064bbe938f38727dd163aae9c95e2185b8075234 /transport.c | |
| parent | 96ec7b1e708863d0cd6b8e72a986d6f0a1bb64db (diff) | |
| download | git-8cad4744ee37ebec1d9491a1381ec1771a1ba795.zip git-8cad4744ee37ebec1d9491a1381ec1771a1ba795.tar.gz git-8cad4744ee37ebec1d9491a1381ec1771a1ba795.tar.bz2 | |
Rename resolve_ref() to resolve_ref_unsafe()
resolve_ref() may return a pointer to a shared buffer and can be
overwritten by the next resolve_ref() calls. Callers need to
pay attention, not to keep the pointer when the next call happens.
Rename with "_unsafe" suffix to warn developers (or reviewers) before
introducing new call sites.
This patch is generated using the following command
git grep -l 'resolve_ref(' -- '*.[ch]'|xargs sed -i 's/resolve_ref(/resolve_ref_unsafe(/g'
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'transport.c')
| -rw-r--r-- | transport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/transport.c b/transport.c index 51814b5..e9797c0 100644 --- a/transport.c +++ b/transport.c @@ -163,7 +163,7 @@ static void set_upstreams(struct transport *transport, struct ref *refs, /* Follow symbolic refs (mainly for HEAD). */ localname = ref->peer_ref->name; remotename = ref->name; - tmp = resolve_ref(localname, sha, 1, &flag); + tmp = resolve_ref_unsafe(localname, sha, 1, &flag); if (tmp && flag & REF_ISSYMREF && !prefixcmp(tmp, "refs/heads/")) localname = tmp; |