diff options
| author | Erik Faye-Lund <kusmabite@gmail.com> | 2014-01-17 14:17:09 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-01-17 20:09:26 (GMT) |
| commit | 7edc02f4deedb3a11abeb328dc2596b2886c2f47 (patch) | |
| tree | f592d5687516f56552669dd16e34bfbc8d538be1 /transport-helper.c | |
| parent | 4224916ae979204f13db2996d9e32490e0acb90f (diff) | |
| download | git-7edc02f4deedb3a11abeb328dc2596b2886c2f47.zip git-7edc02f4deedb3a11abeb328dc2596b2886c2f47.tar.gz git-7edc02f4deedb3a11abeb328dc2596b2886c2f47.tar.bz2 | |
prefer xwrite instead of write
Our xwrite wrapper already deals with a few potential hazards, and
are as such more robust. Prefer it instead of write to get the
robustness benefits everywhere.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Reviewed-and-improved-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'transport-helper.c')
| -rw-r--r-- | transport-helper.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/transport-helper.c b/transport-helper.c index 673b7c2..ea34b39 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -1129,9 +1129,8 @@ static int udt_do_write(struct unidirectional_transfer *t) return 0; /* Nothing to write. */ transfer_debug("%s is writable", t->dest_name); - bytes = write(t->dest, t->buf, t->bufuse); - if (bytes < 0 && errno != EWOULDBLOCK && errno != EAGAIN && - errno != EINTR) { + bytes = xwrite(t->dest, t->buf, t->bufuse); + if (bytes < 0 && errno != EWOULDBLOCK) { error("write(%s) failed: %s", t->dest_name, strerror(errno)); return -1; } else if (bytes > 0) { |