diff options
| author | Eric Wong <normalperson@yhbt.net> | 2014-05-06 00:17:14 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-05-06 19:23:58 (GMT) |
| commit | daa22c6f8da466bd7a438f1bc27375fd737ffcf3 (patch) | |
| tree | dc6e1dcb229c908bdd71bbfed713fb6e06b4df17 /t | |
| parent | 0bc85abb7aa9b24b093253018801a0fb43d01122 (diff) | |
| download | git-daa22c6f8da466bd7a438f1bc27375fd737ffcf3.zip git-daa22c6f8da466bd7a438f1bc27375fd737ffcf3.tar.gz git-daa22c6f8da466bd7a438f1bc27375fd737ffcf3.tar.bz2 | |
config: preserve config file permissions on edits
Users may already store sensitive data such as imap.pass in
.git/config; making the file world-readable when "git config"
is called to edit means their password would be compromised
on a shared system.
[v2: updated for section renames, as noted by Junio]
Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rwxr-xr-x | t/t1300-repo-config.sh | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh index 9673593..ba41bc9 100755 --- a/t/t1300-repo-config.sh +++ b/t/t1300-repo-config.sh @@ -1154,4 +1154,14 @@ test_expect_failure 'adding a key into an empty section reuses header' ' test_cmp expect .git/config ' +test_expect_success POSIXPERM,PERL 'preserves existing permissions' ' + chmod 0600 .git/config && + git config imap.pass Hunter2 && + perl -e \ + "die q(badset) if ((stat(q(.git/config)))[2] & 07777) != 0600" && + git config --rename-section imap pop && + perl -e \ + "die q(badrename) if ((stat(q(.git/config)))[2] & 07777) != 0600" +' + test_done |