diff options
| author | René Scharfe <l.s.r@web.de> | 2017-06-27 17:03:30 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-06-27 17:58:30 (GMT) |
| commit | 4269974179ff4fc2a970c972330ba5b7f26a323b (patch) | |
| tree | 86b9aa02c0176cf03b2aab35eff21c586c897d5c /t | |
| parent | 773e3a2e0226cffac6c813c2d3bea5ba480675d8 (diff) | |
| download | git-4269974179ff4fc2a970c972330ba5b7f26a323b.zip git-4269974179ff4fc2a970c972330ba5b7f26a323b.tar.gz git-4269974179ff4fc2a970c972330ba5b7f26a323b.tar.bz2 | |
apply: check git diffs for missing old filenames
2c93286a (fix "git apply --index ..." not to deref NULL) added a check
for git patches missing a +++ line, preventing a segfault. Check for
missing --- lines as well, and add a test for each case.
Found by Vegard Nossum using AFL.
Original-patch-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rwxr-xr-x | t/t4133-apply-filenames.sh | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/t/t4133-apply-filenames.sh b/t/t4133-apply-filenames.sh index 2ecb421..c5ed3b1 100755 --- a/t/t4133-apply-filenames.sh +++ b/t/t4133-apply-filenames.sh @@ -35,4 +35,28 @@ test_expect_success 'apply diff with inconsistent filenames in headers' ' test_i18ngrep "inconsistent old filename" err ' +test_expect_success 'apply diff with new filename missing from headers' ' + cat >missing_new_filename.diff <<-\EOF && + diff --git a/f b/f + index 0000000..d00491f + --- a/f + @@ -0,0 +1 @@ + +1 + EOF + test_must_fail git apply missing_new_filename.diff 2>err && + test_i18ngrep "lacks filename information" err +' + +test_expect_success 'apply diff with old filename missing from headers' ' + cat >missing_old_filename.diff <<-\EOF && + diff --git a/f b/f + index d00491f..0000000 + +++ b/f + @@ -1 +0,0 @@ + -1 + EOF + test_must_fail git apply missing_old_filename.diff 2>err && + test_i18ngrep "lacks filename information" err +' + test_done |