path: root/t
diff options
authorNguyễn Thái Ngọc Duy <>2016-10-24 10:42:19 (GMT)
committerJunio C Hamano <>2016-10-24 17:47:28 (GMT)
commit425a28e0a4edfc39585cec6b0b6368c0ad9dbf7e (patch)
tree453a583c0e244d2edb0f729f831e5d7c76f5894c /t
parent21f862b498925194f8f1ebe8203b7a7df756555b (diff)
diff-lib: allow ita entries treated as "not yet exist in index"
When comparing the index and the working tree to show which paths are new, and comparing the tree recorded in the HEAD and the index to see if committing the contents recorded in the index would result in an empty commit, we would want the former comparison to say "these are new paths" and the latter to say "there is no change" for paths that are marked as intent-to-add. We made a similar attempt at d95d728a ("diff-lib.c: adjust position of i-t-a entries in diff", 2015-03-16), which redefined the semantics of these two comparison modes globally, which was a disaster and had to be reverted at 78cc1a54 ("Revert "diff-lib.c: adjust position of i-t-a entries in diff"", 2015-06-23). To make sure we do not repeat the same mistake, introduce a new internal diffopt option so that this different semantics can be asked for only by callers that ask it, while making sure other unaudited callers will get the same comparison result. Signed-off-by: Nguyễn Thái Ngọc Duy <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 't')
2 files changed, 17 insertions, 3 deletions
diff --git a/t/ b/t/
index 8f22c43..2276e4e 100755
--- a/t/
+++ b/t/
@@ -5,10 +5,24 @@ test_description='Intent to add'
. ./
test_expect_success 'intent to add' '
+ test_commit 1 &&
+ git rm 1.t &&
+ echo hello >1.t &&
echo hello >file &&
echo hello >elif &&
git add -N file &&
- git add elif
+ git add elif &&
+ git add -N 1.t
+test_expect_success 'git status' '
+ git status --porcelain | grep -v actual >actual &&
+ cat >expect <<-\EOF &&
+ DA 1.t
+ A elif
+ A file
+ test_cmp expect actual
test_expect_success 'check result of "add -N"' '
diff --git a/t/ b/t/
index 3012a4d..e319fa2 100755
--- a/t/
+++ b/t/
@@ -246,8 +246,8 @@ test_expect_success 'verify --intent-to-add output' '
git add --intent-to-add intent1.add intent2.add &&
cat >expect <<-EOF &&
- 1 AM N... 000000 100644 100644 $_z40 $EMPTY_BLOB intent1.add
- 1 AM N... 000000 100644 100644 $_z40 $EMPTY_BLOB intent2.add
+ 1 .A N... 000000 000000 100644 $_z40 $_z40 intent1.add
+ 1 .A N... 000000 000000 100644 $_z40 $_z40 intent2.add
git status --porcelain=v2 >actual &&