summaryrefslogtreecommitdiff
path: root/t
diff options
context:
space:
mode:
authorElia Pinto <gitter.spiros@gmail.com>2014-04-30 16:22:57 (GMT)
committerJunio C Hamano <gitster@pobox.com>2014-04-30 18:08:05 (GMT)
commit38b2e5d12cbe681bff8f31cf10e3de8bd6f6db52 (patch)
tree8d6ce22c35f3566420652446910f41ee46062919 /t
parente1d6b55d5db4c1ad305b5ac6e4f1bb4bea3c1bee (diff)
downloadgit-38b2e5d12cbe681bff8f31cf10e3de8bd6f6db52.zip
git-38b2e5d12cbe681bff8f31cf10e3de8bd6f6db52.tar.gz
git-38b2e5d12cbe681bff8f31cf10e3de8bd6f6db52.tar.bz2
t4010-diff-pathspec.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
-rwxr-xr-xt/t4010-diff-pathspec.sh4
1 files changed, 2 insertions, 2 deletions
diff --git a/t/t4010-diff-pathspec.sh b/t/t4010-diff-pathspec.sh
index 2bb9736..bf07841 100755
--- a/t/t4010-diff-pathspec.sh
+++ b/t/t4010-diff-pathspec.sh
@@ -18,7 +18,7 @@ test_expect_success \
mkdir path1 &&
echo rezrov >path1/file1 &&
git update-index --add file0 path1/file1 &&
- tree=`git write-tree` &&
+ tree=$(git write-tree) &&
echo "$tree" &&
echo nitfol >file0 &&
echo yomin >path1/file1 &&
@@ -131,7 +131,7 @@ test_expect_success 'diff multiple wildcard pathspecs' '
mkdir path2 &&
echo rezrov >path2/file1 &&
git update-index --add path2/file1 &&
- tree3=`git write-tree` &&
+ tree3=$(git write-tree) &&
git diff --name-only $tree $tree3 -- "path2*1" "path1*1" >actual &&
cat <<-\EOF >expect &&
path1/file1