summaryrefslogtreecommitdiff
path: root/t/t9809-git-p4-client-view.sh
diff options
context:
space:
mode:
authorPete Wyckoff <pw@padd.com>2013-01-27 03:11:08 (GMT)
committerJunio C Hamano <gitster@pobox.com>2013-01-27 06:00:38 (GMT)
commit6112541b444b52d5ac83f491eabefbf571da4997 (patch)
treeb18fb5488f0545a92c91c30f0e40104b72905470 /t/t9809-git-p4-client-view.sh
parentdaa38f4ae0afdc6357c547d2f6bd5270e1e4151a (diff)
downloadgit-6112541b444b52d5ac83f491eabefbf571da4997.zip
git-6112541b444b52d5ac83f491eabefbf571da4997.tar.gz
git-6112541b444b52d5ac83f491eabefbf571da4997.tar.bz2
git p4 test: avoid loop in client_view
The printf command re-interprets the format string as long as there are arguments to consume. Use this to simplify a for loop in the client_view() library function. This requires a fix to one of the client_view callers. An errant \n in the string was converted into a harmless newline in the input to "p4 client -i", but now shows up as a literal \n as passed through by "%s". Remove the \n. Based-on-patch-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Pete Wyckoff <pw@padd.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9809-git-p4-client-view.sh')
-rwxr-xr-xt/t9809-git-p4-client-view.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t9809-git-p4-client-view.sh b/t/t9809-git-p4-client-view.sh
index 281be29..0b58fb9 100755
--- a/t/t9809-git-p4-client-view.sh
+++ b/t/t9809-git-p4-client-view.sh
@@ -196,7 +196,7 @@ test_expect_success 'exclusion single file' '
test_expect_success 'overlay wildcard' '
client_view "//depot/dir1/... //client/cli/..." \
- "+//depot/dir2/... //client/cli/...\n" &&
+ "+//depot/dir2/... //client/cli/..." &&
files="cli/file11 cli/file12 cli/file21 cli/file22" &&
client_verify $files &&
test_when_finished cleanup_git &&