diff options
| author | Denton Liu <liu.denton@gmail.com> | 2020-04-20 08:54:44 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-04-20 20:30:11 (GMT) |
| commit | bf1218106835fb06f8862c6727dd4453e9ea5fd9 (patch) | |
| tree | 3557e9f783f39946f53adb6b5db5dbf5d21494fa /t/t9164-git-svn-dcommit-concurrent.sh | |
| parent | 5c65897d2b591f1d023a52c93c729c2b5a90a2df (diff) | |
| download | git-bf1218106835fb06f8862c6727dd4453e9ea5fd9.zip git-bf1218106835fb06f8862c6727dd4453e9ea5fd9.tar.gz git-bf1218106835fb06f8862c6727dd4453e9ea5fd9.tar.bz2 | |
t9164: use test_must_fail only on git commands
The `test_must_fail` function should only be used for git commands;
we are not in the business of catching segmentation fault by external
commands. Shell helper functions test_cmp and svn_cmd used in this
script are wrappers around external commands, so just use `! cmd`
instead of `test_must_fail cmd`
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9164-git-svn-dcommit-concurrent.sh')
| -rwxr-xr-x | t/t9164-git-svn-dcommit-concurrent.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/t9164-git-svn-dcommit-concurrent.sh b/t/t9164-git-svn-dcommit-concurrent.sh index 90346ff..8466269 100755 --- a/t/t9164-git-svn-dcommit-concurrent.sh +++ b/t/t9164-git-svn-dcommit-concurrent.sh @@ -92,7 +92,7 @@ test_expect_success 'check if post-commit hook creates a concurrent commit' ' echo 1 >> file && svn_cmd commit -m "changing file" && svn_cmd up && - test_must_fail test_cmp auto_updated_file au_file_saved + ! test_cmp auto_updated_file au_file_saved ) ' @@ -103,7 +103,7 @@ test_expect_success 'check if pre-commit hook fails' ' echo 2 >> file && svn_cmd commit -m "changing file once again" && echo 3 >> file && - test_must_fail svn_cmd commit -m "this commit should fail" && + ! svn_cmd commit -m "this commit should fail" && svn_cmd revert file ) ' |