diff options
| author | Jonathan Tan <jonathantanmy@google.com> | 2020-05-11 17:43:10 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-05-11 18:18:01 (GMT) |
| commit | 7167a62b9e2f648adc11411446f876f2458722a5 (patch) | |
| tree | eb0b58dfdde6cd2ad37d1aff90f10ebb41c65f56 /t/t5581-http-curl-verbose.sh | |
| parent | 373e9bd66e2ba468f490e5e4ec1ccbe47853f8cd (diff) | |
| download | git-7167a62b9e2f648adc11411446f876f2458722a5.zip git-7167a62b9e2f648adc11411446f876f2458722a5.tar.gz git-7167a62b9e2f648adc11411446f876f2458722a5.tar.bz2 | |
http, imap-send: stop using CURLOPT_VERBOSE
Whenever GIT_CURL_VERBOSE is set, teach Git to behave as if
GIT_TRACE_CURL=1 and GIT_TRACE_CURL_NO_DATA=1 is set, instead of setting
CURLOPT_VERBOSE.
This is to prevent inadvertent revelation of sensitive data. In
particular, GIT_CURL_VERBOSE redacts neither the "Authorization" header
nor any cookies specified by GIT_REDACT_COOKIES.
Unifying the tracing mechanism also has the future benefit that any
improvements to the tracing mechanism will benefit both users of
GIT_CURL_VERBOSE and GIT_TRACE_CURL, and we do not need to remember to
implement any improvement twice.
Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5581-http-curl-verbose.sh')
| -rwxr-xr-x | t/t5581-http-curl-verbose.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t5581-http-curl-verbose.sh b/t/t5581-http-curl-verbose.sh index 5129b07..927aad0 100755 --- a/t/t5581-http-curl-verbose.sh +++ b/t/t5581-http-curl-verbose.sh @@ -20,7 +20,7 @@ test_expect_success 'failure in git-upload-pack is shown' ' test_might_fail env GIT_CURL_VERBOSE=1 \ git clone "$HTTPD_URL/error_git_upload_pack/smart/repo.git" \ 2>curl_log && - grep "< HTTP/1.1 500 Intentional Breakage" curl_log + grep "<= Recv header: HTTP/1.1 500 Intentional Breakage" curl_log ' test_done |