diff options
author | Junio C Hamano <gitster@pobox.com> | 2022-01-04 00:24:15 (GMT) |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-01-04 00:24:15 (GMT) |
commit | 4f4b18497aea75425506097de7225df8c7cf5c66 (patch) | |
tree | 894010237b6188081699ace29bf5796f42bd4362 /t/t5505-remote.sh | |
parent | 0dc90d954db852c6604796b8d817365f94e92a16 (diff) | |
parent | 0c51d6b4aec9f1959d148960cb55155b676cec78 (diff) | |
download | git-4f4b18497aea75425506097de7225df8c7cf5c66.zip git-4f4b18497aea75425506097de7225df8c7cf5c66.tar.gz git-4f4b18497aea75425506097de7225df8c7cf5c66.tar.bz2 |
Merge branch 'es/test-chain-lint'
Broken &&-chains in the test scripts have been corrected.
* es/test-chain-lint:
t6000-t9999: detect and signal failure within loop
t5000-t5999: detect and signal failure within loop
t4000-t4999: detect and signal failure within loop
t0000-t3999: detect and signal failure within loop
tests: simplify by dropping unnecessary `for` loops
tests: apply modern idiom for exiting loop upon failure
tests: apply modern idiom for signaling test failure
tests: fix broken &&-chains in `{...}` groups
tests: fix broken &&-chains in `$(...)` command substitutions
tests: fix broken &&-chains in compound statements
tests: use test_write_lines() to generate line-oriented output
tests: simplify construction of large blocks of text
t9107: use shell parameter expansion to avoid breaking &&-chain
t6300: make `%(raw:size) --shell` test more robust
t5516: drop unnecessary subshell and command invocation
t4202: clarify intent by creating expected content less cleverly
t1020: avoid aborting entire test script when one test fails
t1010: fix unnoticed failure on Windows
t/lib-pager: use sane_unset() to avoid breaking &&-chain
Diffstat (limited to 't/t5505-remote.sh')
-rwxr-xr-x | t/t5505-remote.sh | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh index 7ce1a28..9ab3154 100755 --- a/t/t5505-remote.sh +++ b/t/t5505-remote.sh @@ -1329,7 +1329,6 @@ test_expect_success 'unqualified <dst> refspec DWIM and advice' ' ( cd test && git tag -a -m "Some tag" some-tag main && - exit_with=true && for type in commit tag tree blob do if test "$type" = "blob" @@ -1345,9 +1344,8 @@ test_expect_success 'unqualified <dst> refspec DWIM and advice' ' push origin $oid:dst 2>err && test_i18ngrep "error: The destination you" err && test_i18ngrep ! "hint: Did you mean" err || - exit_with=false - done && - $exit_with + exit 1 + done ) ' |