diff options
author | Denton Liu <liu.denton@gmail.com> | 2019-12-09 13:10:46 (GMT) |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2019-12-09 21:37:20 (GMT) |
commit | 8164c961e16834da283cbf5ac5d22313b982a484 (patch) | |
tree | fb4dc18bb93b80061d0879985538d87a82f298f5 /t/t5319-multi-pack-index.sh | |
parent | 452538c3586a76939faf43019fb7c21b3147309b (diff) | |
download | git-8164c961e16834da283cbf5ac5d22313b982a484.zip git-8164c961e16834da283cbf5ac5d22313b982a484.tar.gz git-8164c961e16834da283cbf5ac5d22313b982a484.tar.bz2 |
format-patch: use --notes behavior for format.notes
When we had multiple `format.notes` config values where we had `<ref1>`,
`false`, `<ref2>` (in that order), then we would print out the notes for
both `<ref1>` and `<ref2>`. This doesn't make sense, however, since we
parse the config in a top-down manner and a `false` should be able to
override previous configurations, just like how `--no-notes` will
override previous `--notes`.
Duplicate the logic that handles the `--[no-]notes[=]` option to
`format.notes` for consistency. As a result, when parsing the config
from top to bottom, `format.notes = true` will behave like `--notes`,
`format.notes = <ref>` will behave like `--notes=<ref>` and
`format.notes = false` will behave like `--no-notes`.
This change isn't strictly backwards compatible but since it is an edge
case where a sane user would not mix notes refs with `false` and this
feature is relatively new (released only in v2.23.0), this change should
be harmless.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5319-multi-pack-index.sh')
0 files changed, 0 insertions, 0 deletions