diff options
| author | Ruud van Asseldonk <dev@veniogames.com> | 2019-11-26 00:02:46 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-11-27 01:59:15 (GMT) |
| commit | 13ca8fb79e37f66e31b20c4444fa23ccd671c03a (patch) | |
| tree | 3620c8fbff347f87bee4f1a9f3091ae129b0164e /t/t5150-request-pull.sh | |
| parent | d9f6f3b6195a0ca35642561e530798ad1469bd41 (diff) | |
| download | git-13ca8fb79e37f66e31b20c4444fa23ccd671c03a.zip git-13ca8fb79e37f66e31b20c4444fa23ccd671c03a.tar.gz git-13ca8fb79e37f66e31b20c4444fa23ccd671c03a.tar.bz2 | |
t5150: skip request-pull test if Perl is disabled
The git-request-pull.sh script invokes Perl, so it requires Perl to be
available, but the associated test t5150 does not skip itself when Perl
has been disabled, which then makes subtest 4 through 10 fail. Subtest 3
still passes, but for the wrong reasons (it expects git-request-pull to
fail, and it does fail when Perl is not available). The initial two
subtests that do pass are only doing setup.
To prevent t5150 from failing the build when NO_PERL=1, add a check that
sets skip_all when "! test_have_prereq PERL", just like how for example
t3701-add-interactive skips itself when Perl has been disabled.
Signed-off-by: Ruud van Asseldonk <dev@veniogames.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5150-request-pull.sh')
| -rwxr-xr-x | t/t5150-request-pull.sh | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/t/t5150-request-pull.sh b/t/t5150-request-pull.sh index 852dcd9..1ad4ecc 100755 --- a/t/t5150-request-pull.sh +++ b/t/t5150-request-pull.sh @@ -4,6 +4,12 @@ test_description='Test workflows involving pull request.' . ./test-lib.sh +if ! test_have_prereq PERL +then + skip_all='skipping request-pull tests, perl not available' + test_done +fi + test_expect_success 'setup' ' git init --bare upstream.git && |