diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-01-05 19:42:37 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2021-01-05 22:58:29 (GMT) |
| commit | 5c2303e0c7a981528dae68d4979d3bfdc2526276 (patch) | |
| tree | 0188887cbbf97142d8a8854b23c095d81d3bd388 /t/t3800-mktag.sh | |
| parent | 317c1762798f9e1ee0cb8096a2071561a8bb1fdc (diff) | |
| download | git-5c2303e0c7a981528dae68d4979d3bfdc2526276.zip git-5c2303e0c7a981528dae68d4979d3bfdc2526276.tar.gz git-5c2303e0c7a981528dae68d4979d3bfdc2526276.tar.bz2 | |
mktag tests: don't create "mytag" twice
Change a test added in e0aaf781f6 (mktag.c: improve verification of
tagger field and tests, 2008-03-27) to not create "mytag", which
should only be created and verified at the end in an earlier test
added in 446c6faec6 (New tests and en-passant modifications to mktag.,
2006-07-29).
While we're at it let's prevent a similar logic error from creeping
into the test by asserting that "mytag" doesn't exist before we create
it. Let's do this by moving the test to use "update-ref", instead of
our own homebrew ad-hoc refstore update.
We're not really testing for anything yet by creating the tag at the
end here. A subsequent commit will change that.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t3800-mktag.sh')
| -rwxr-xr-x | t/t3800-mktag.sh | 17 |
1 files changed, 5 insertions, 12 deletions
diff --git a/t/t3800-mktag.sh b/t/t3800-mktag.sh index c542c3e..bb300d5 100755 --- a/t/t3800-mktag.sh +++ b/t/t3800-mktag.sh @@ -222,7 +222,7 @@ EOF test_expect_success \ 'allow empty tag email' \ - 'git mktag <tag.sig >.git/refs/tags/mytag' + 'git mktag <tag.sig' ############################################################ # 16. disallow spaces in tag email @@ -348,16 +348,9 @@ tagger T A Gger <tagger@example.com> 1206478233 -0500 EOF -test_expect_success \ - 'create valid tag' \ - 'git mktag <tag.sig >.git/refs/tags/mytag' - -############################################################ -# 25. check mytag - -test_expect_success \ - 'check mytag' \ - 'git tag -l | grep mytag' - +test_expect_success 'create valid tag' ' + git mktag <tag.sig >hash && + git update-ref refs/tags/mytag $(cat hash) $(test_oid zero) +' test_done |