diff options
author | Elijah Newren <newren@gmail.com> | 2020-03-27 00:48:54 (GMT) |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-03-27 18:33:30 (GMT) |
commit | 4ee5d50fc39f8d41f67c3c9a936084fb914c9a50 (patch) | |
tree | 6a31649013ebfd69537b37d4ea88f4be9de75592 /t/t1091-sparse-checkout-builtin.sh | |
parent | f56f31af0301f6446f8689ba1a997d74fb82f45f (diff) | |
download | git-4ee5d50fc39f8d41f67c3c9a936084fb914c9a50.zip git-4ee5d50fc39f8d41f67c3c9a936084fb914c9a50.tar.gz git-4ee5d50fc39f8d41f67c3c9a936084fb914c9a50.tar.bz2 |
sparse-checkout: use improved unpack_trees porcelain messages
setup_unpack_trees_porcelain() provides much improved error/warning
messages; instead of a message that assumes that there is only one path
with a given problem despite being used by code that intentionally is
grouping and showing errors together, it uses a message designed to be
used with groups of paths. For example, this transforms
error: Entry ' folder1/a
folder2/a
' not uptodate. Cannot update sparse checkout.
into
error: Cannot update sparse checkout: the following entries are not up to date:
folder1/a
folder2/a
In the past the suboptimal messages were never actually triggered
because we would error out if the working directory wasn't clean before
we even called unpack_trees(). The previous commit changed that,
though, so let's use the better error messages.
Reviewed-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t1091-sparse-checkout-builtin.sh')
-rwxr-xr-x | t/t1091-sparse-checkout-builtin.sh | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/t/t1091-sparse-checkout-builtin.sh b/t/t1091-sparse-checkout-builtin.sh index a991e0a..9bc65d3 100755 --- a/t/t1091-sparse-checkout-builtin.sh +++ b/t/t1091-sparse-checkout-builtin.sh @@ -328,12 +328,10 @@ test_expect_success 'sparse-checkout (init|set|disable) warns with dirty status' echo dirty >dirty/folder1/a && git -C dirty sparse-checkout init 2>err && - test_i18ngrep "error" err && - test_i18ngrep "Cannot update sparse checkout" err && + test_i18ngrep "error.*Cannot update sparse checkout" err && git -C dirty sparse-checkout set /folder2/* /deep/deeper1/* 2>err && - test_i18ngrep "error" err && - test_i18ngrep "Cannot update sparse checkout" err && + test_i18ngrep "error.*Cannot update sparse checkout" err && test_path_is_file dirty/folder1/a && git -C dirty sparse-checkout disable 2>err && |