diff options
| author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2018-01-03 16:54:54 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-01-03 23:55:50 (GMT) |
| commit | 89a70b80ebabd237bb407f9321f24677f4f1d16d (patch) | |
| tree | 1c084796ddd1d26f80bd4e2f34132b151570c0ad /t/t0302-credential-store.sh | |
| parent | 567c53d00f194a2826dda0b6be5d66283138377d (diff) | |
| download | git-89a70b80ebabd237bb407f9321f24677f4f1d16d.zip git-89a70b80ebabd237bb407f9321f24677f4f1d16d.tar.gz git-89a70b80ebabd237bb407f9321f24677f4f1d16d.tar.bz2 | |
t0302 & t3900: add forgotten quotes
When cleaning up files in the $HOME directory, it really makes sense to
quote the path, especially in Git's test suite, where the HOME directory
is *guaranteed* to contain spaces in its name.
It would appear that those two tests pass even without cleaning up the
files, but really more by pure chance than by design (the cleanup seems
not actually to be necessary).
However, if anybody would have a left-over `trash/` directory in Git's
`t/` directory, these tests would fail, because they would all of a
sudden try to delete that directory, but without the `-r` (recursive)
flag. That is how this issue was found.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t0302-credential-store.sh')
| -rwxr-xr-x | t/t0302-credential-store.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t0302-credential-store.sh b/t/t0302-credential-store.sh index 1d8d1f2..d6b54e8 100755 --- a/t/t0302-credential-store.sh +++ b/t/t0302-credential-store.sh @@ -37,7 +37,7 @@ helper_test store unset XDG_CONFIG_HOME test_expect_success 'if custom xdg file exists, home and xdg files not created' ' - test_when_finished "rm -f $HOME/xdg/git/credentials" && + test_when_finished "rm -f \"$HOME/xdg/git/credentials\"" && test -s "$HOME/xdg/git/credentials" && test_path_is_missing "$HOME/.git-credentials" && test_path_is_missing "$HOME/.config/git/credentials" |