diff options
| author | Stefan Beller <sbeller@google.com> | 2018-12-15 00:09:42 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-12-28 18:06:33 (GMT) |
| commit | ff509c585e847c5fc40c40d35e7d745dd81363bd (patch) | |
| tree | eaceb9aa686c53e8642a6abb98cfa5c2a348ca59 /t/helper | |
| parent | b6b24fc57bb2132955756771f9588a3cfb050350 (diff) | |
| download | git-ff509c585e847c5fc40c40d35e7d745dd81363bd.zip git-ff509c585e847c5fc40c40d35e7d745dd81363bd.tar.gz git-ff509c585e847c5fc40c40d35e7d745dd81363bd.tar.bz2 | |
t/helper/test-repository: celebrate independence from the_repository
dade47c06c (commit-graph: add repo arg to graph readers, 2018-07-11)
brought more independence from the_repository to the commit graph, however
it was not completely independent of the_repository, as the previous
patches show.
To ensure we're not accessing the_repository by accident, we'd ideally
assign NULL to the_repository to trigger a segfault on access.
We currently have a temporary hack in cache.h, which relies on
the_hash_algo (which is a short form of the_repository->hash_algo) to
be set, so we cannot do that. The next best thing is to set all fields of
the_repository to 0, so any accidental access is more likely to be found.
Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/helper')
| -rw-r--r-- | t/helper/test-repository.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/t/helper/test-repository.c b/t/helper/test-repository.c index 6a84a53..f7f8618 100644 --- a/t/helper/test-repository.c +++ b/t/helper/test-repository.c @@ -17,6 +17,11 @@ static void test_parse_commit_in_graph(const char *gitdir, const char *worktree, setup_git_env(gitdir); + memset(the_repository, 0, sizeof(*the_repository)); + + /* TODO: Needed for temporary hack in hashcmp, see 183a638b7da. */ + repo_set_hash_algo(the_repository, GIT_HASH_SHA1); + if (repo_init(&r, gitdir, worktree)) die("Couldn't init repo"); @@ -43,6 +48,11 @@ static void test_get_commit_tree_in_graph(const char *gitdir, setup_git_env(gitdir); + memset(the_repository, 0, sizeof(*the_repository)); + + /* TODO: Needed for temporary hack in hashcmp, see 183a638b7da. */ + repo_set_hash_algo(the_repository, GIT_HASH_SHA1); + if (repo_init(&r, gitdir, worktree)) die("Couldn't init repo"); |