diff options
| author | Eric Sunshine <sunshine@sunshineco.com> | 2021-12-13 06:30:46 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2021-12-13 22:15:28 (GMT) |
| commit | 5459bc1bbb54536df18b034afd390f899bda37be (patch) | |
| tree | 21cb3b85054bcca224617cae862c50ceff4765ce /t/chainlint/subshell-here-doc.test | |
| parent | 925d7304d2a5f5dda9fbe3f541338bb87083f6b2 (diff) | |
| download | git-5459bc1bbb54536df18b034afd390f899bda37be.zip git-5459bc1bbb54536df18b034afd390f899bda37be.tar.gz git-5459bc1bbb54536df18b034afd390f899bda37be.tar.bz2 | |
t/chainlint/*.test: fix invalid test cases due to mixing quote types
The chainlint self-test code snippets are supposed to represent the body
of a test_expect_success() or test_expect_failure(), yet the contents of
a few tests would have caused the shell to report syntax errors had they
been real test bodies due to the mix of single- and double-quotes.
Although chainlint.sed, with its simplistic heuristics, is blind to this
problem, a future more robust chainlint implementation might not have
such a limitation. Therefore, stop mixing quote types haphazardly in
those tests and unify quoting throughout. While at it, drop chunks of
tests which merely repeat what is already tested elsewhere but with
alternative quotes.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/chainlint/subshell-here-doc.test')
| -rw-r--r-- | t/chainlint/subshell-here-doc.test | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/t/chainlint/subshell-here-doc.test b/t/chainlint/subshell-here-doc.test index 0cce907..d40eb65 100644 --- a/t/chainlint/subshell-here-doc.test +++ b/t/chainlint/subshell-here-doc.test @@ -8,7 +8,7 @@ nevermore... EOF -# LINT: missing "&&" on 'cat' +# LINT: missing "&&" on "cat" cat <<EOF >bip fish fly high EOF @@ -27,10 +27,6 @@ EOF glink FIZZ ARBITRARY - cat <<-'ARBITRARY2' >bup2 && - glink - FIZZ - ARBITRARY2 cat <<-"ARBITRARY3" >bup3 && glink FIZZ |