summaryrefslogtreecommitdiff
path: root/strbuf.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2015-04-16 08:48:23 (GMT)
committerJunio C Hamano <gitster@pobox.com>2015-04-16 15:15:04 (GMT)
commit3446a59b3950d57960e27f8a2c7e41462bd2bcf4 (patch)
treed3bd30702df73b0fadcb936876fb703de385fef8 /strbuf.c
parent2dfb2e07cb0cb979f630643b57dca579a0359a9d (diff)
downloadgit-3446a59b3950d57960e27f8a2c7e41462bd2bcf4.zip
git-3446a59b3950d57960e27f8a2c7e41462bd2bcf4.tar.gz
git-3446a59b3950d57960e27f8a2c7e41462bd2bcf4.tar.bz2
strbuf_getwholeline: use getc macro
strbuf_getwholeline calls fgetc in a tight loop. Using the getc form, which can be implemented as a macro, should be faster (and we do not care about it evaluating our argument twice, as we just have a plain variable). On my glibc system, running "git rev-parse refs/heads/does-not-exist" on a file with an extremely large (1.6GB) packed-refs file went from (best of 3 runs): real 0m19.383s user 0m18.876s sys 0m0.528s to: real 0m18.900s user 0m18.472s sys 0m0.448s for a wall-clock speedup of 2.5%. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'strbuf.c')
-rw-r--r--strbuf.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/strbuf.c b/strbuf.c
index 88cafd4..14f337d 100644
--- a/strbuf.c
+++ b/strbuf.c
@@ -443,7 +443,7 @@ int strbuf_getwholeline(struct strbuf *sb, FILE *fp, int term)
return EOF;
strbuf_reset(sb);
- while ((ch = fgetc(fp)) != EOF) {
+ while ((ch = getc(fp)) != EOF) {
strbuf_grow(sb, 1);
sb->buf[sb->len++] = ch;
if (ch == term)