summaryrefslogtreecommitdiff
path: root/sha1_name.c
diff options
context:
space:
mode:
authorRamkumar Ramachandra <artagnon@gmail.com>2013-05-07 21:55:09 (GMT)
committerJunio C Hamano <gitster@pobox.com>2013-05-08 16:15:37 (GMT)
commite883a057a9da3c738dd6f6e2f1aa9498885ae1e8 (patch)
treeb0e526403eff3761cacf6f94384a445611a67ae7 /sha1_name.c
parentb5f769a0d71bc3f13f916db849ef6b4768359c4e (diff)
downloadgit-e883a057a9da3c738dd6f6e2f1aa9498885ae1e8.zip
git-e883a057a9da3c738dd6f6e2f1aa9498885ae1e8.tar.gz
git-e883a057a9da3c738dd6f6e2f1aa9498885ae1e8.tar.bz2
sha1_name: don't waste cycles in the @-parsing loop
The @-parsing loop unnecessarily checks for the sequence "@{" from (len - 2) unnecessarily. We can safely check from (len - 4). Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'sha1_name.c')
-rw-r--r--sha1_name.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sha1_name.c b/sha1_name.c
index 6530ddd..7b59f6f 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -445,7 +445,7 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
/* basic@{time or number or -number} format to query ref-log */
reflog_len = at = 0;
if (len && str[len-1] == '}') {
- for (at = len-2; at >= 0; at--) {
+ for (at = len-4; at >= 0; at--) {
if (str[at] == '@' && str[at+1] == '{') {
if (!upstream_mark(str + at, len - at)) {
reflog_len = (len-1) - (at+2);