diff options
| author | Nguyễn Thái Ngọc Duy <pclouds@gmail.com> | 2014-02-20 23:47:47 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-02-24 17:07:12 (GMT) |
| commit | 019d1e65f5bc715a40b1cd77852af0a649753c56 (patch) | |
| tree | d87eb6eb268177c6843964167a26a9f8d886f890 /sha1_file.c | |
| parent | abe601bba52ee6b0bf89d282aa1c3ef5fd89cbb0 (diff) | |
| download | git-019d1e65f5bc715a40b1cd77852af0a649753c56.zip git-019d1e65f5bc715a40b1cd77852af0a649753c56.tar.gz git-019d1e65f5bc715a40b1cd77852af0a649753c56.tar.bz2 | |
sha1_file: fix delta_stack memory leak in unpack_entry
This delta_stack array can grow to any length depending on the actual
delta chain, but we forget to free it. Normally it does not matter
because we use small_delta_stack[] from stack and small_delta_stack
can hold 64-delta chains, more than standard --depth=50 in pack-objects.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'sha1_file.c')
| -rw-r--r-- | sha1_file.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sha1_file.c b/sha1_file.c index b220a47..ca31de2 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -2058,6 +2058,10 @@ void *unpack_entry(struct packed_git *p, off_t obj_offset, *final_size = size; unuse_pack(&w_curs); + + if (delta_stack != small_delta_stack) + free(delta_stack); + return data; } |