diff options
author | Thomas Rast <trast@student.ethz.ch> | 2010-07-24 14:49:04 (GMT) |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2010-07-26 04:57:23 (GMT) |
commit | 730220de8be669257287e9a1f5dde349ace5426a (patch) | |
tree | 397acf0fb781bb98853ea4a5af3d50235ff876fe /sha1-lookup.c | |
parent | 64fdc08dac6694d1e754580e7acb82dfa4988bb9 (diff) | |
download | git-730220de8be669257287e9a1f5dde349ace5426a.zip git-730220de8be669257287e9a1f5dde349ace5426a.tar.gz git-730220de8be669257287e9a1f5dde349ace5426a.tar.bz2 |
Do not unquote + into ' ' in URLs
Since 9d2e942 (decode file:// and ssh:// URLs, 2010-05-23) the URL
logic unquotes escaped URLs. For the %2B type of escape, this is
conformant with RFC 2396. However, it also unquotes + into a space
character, which is only appropriate for the query strings in HTTP.
This notably broke fetching from the gtk+ repository.
We cannot just remove the corresponding code since the same
url_decode_internal() is also used by the HTTP backend to decode query
parameters. Introduce a new argument that controls whether the +
decoding happens, and use it only in the (client-side) url_decode().
Reported-by: Jasper St. Pierre <jstpierre@mecheye.net>
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'sha1-lookup.c')
0 files changed, 0 insertions, 0 deletions