diff options
| author | Junio C Hamano <gitster@pobox.com> | 2012-10-19 05:41:56 (GMT) |
|---|---|---|
| committer | Jeff King <peff@peff.net> | 2012-11-04 13:10:33 (GMT) |
| commit | 0e18bcd5e937b9e5857892e7f5c80c3c5b1da5d4 (patch) | |
| tree | 65ec6c8c507979ede028373a036d21c6c11ce49c /sequencer.c | |
| parent | 7e2010537e96d0a1144520222f20ba1dc3d61441 (diff) | |
| download | git-0e18bcd5e937b9e5857892e7f5c80c3c5b1da5d4.zip git-0e18bcd5e937b9e5857892e7f5c80c3c5b1da5d4.tar.gz git-0e18bcd5e937b9e5857892e7f5c80c3c5b1da5d4.tar.bz2 | |
reencode_string(): introduce and use same_encoding()
Callers of reencode_string() that re-encodes a string from one
encoding to another all used ad-hoc way to bypass the case where the
input and the output encodings are the same. Some did strcmp(),
some did strcasecmp(), yet some others when converting to UTF-8 used
is_encoding_utf8().
Introduce same_encoding() helper function to make these callers use
the same logic. Notably, is_encoding_utf8() has a work-around for
common misconfiguration to use "utf8" to name UTF-8 encoding, which
does not match "UTF-8" hence strcasecmp() would not consider the
same. Make use of it in this helper function.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'sequencer.c')
| -rw-r--r-- | sequencer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sequencer.c b/sequencer.c index bd62680..f2f5b13 100644 --- a/sequencer.c +++ b/sequencer.c @@ -58,7 +58,7 @@ static int get_message(struct commit *commit, struct commit_message *out) out->reencoded_message = NULL; out->message = commit->buffer; - if (strcmp(encoding, git_commit_encoding)) + if (same_encoding(encoding, git_commit_encoding)) out->reencoded_message = reencode_string(commit->buffer, git_commit_encoding, encoding); if (out->reencoded_message) |