diff options
| author | Jeff King <peff@peff.net> | 2012-06-05 08:56:04 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2012-06-05 16:38:00 (GMT) |
| commit | e8320f350f523c3219ff8ec639663193941af57d (patch) | |
| tree | fd9775cede092c35489dbf504607ed814f3e75c0 /run-command.c | |
| parent | 3fe4498197ced84886b4adaddf18f1109b477f8e (diff) | |
| download | git-e8320f350f523c3219ff8ec639663193941af57d.zip git-e8320f350f523c3219ff8ec639663193941af57d.tar.gz git-e8320f350f523c3219ff8ec639663193941af57d.tar.bz2 | |
pager: drop "wait for output to run less" hack
Commit 35ce862 (pager: Work around window resizing bug in
'less', 2007-01-24) causes git's pager sub-process to wait
to receive input after forking but before exec-ing the
pager. To handle this, run-command had to grow a "pre-exec
callback" feature. Unfortunately, this feature does not work
at all on Windows (where we do not fork), and interacts
poorly with run-command's parent notification system. Its
use should be discouraged.
The bug in less was fixed in version 406, which was released
in June 2007. It is probably safe at this point to remove
our workaround. That lets us rip out the preexec_cb feature
entirely.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'run-command.c')
| -rw-r--r-- | run-command.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/run-command.c b/run-command.c index 606791d..dff28a7 100644 --- a/run-command.c +++ b/run-command.c @@ -394,16 +394,6 @@ fail_pipe: unsetenv(*cmd->env); } } - if (cmd->preexec_cb) { - /* - * We cannot predict what the pre-exec callback does. - * Forgo parent notification. - */ - close(child_notifier); - child_notifier = -1; - - cmd->preexec_cb(); - } if (cmd->git_cmd) { execv_git_cmd(cmd->argv); } else if (cmd->use_shell) { |