summaryrefslogtreecommitdiff
path: root/revision.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2012-04-30 00:51:30 (GMT)
committerJunio C Hamano <gitster@pobox.com>2012-04-30 00:51:30 (GMT)
commit6a8989709efbd6d5187005497907264fde026ae9 (patch)
tree9a575ab5e173c5e5f0203a6053531eb3d0055bec /revision.c
parent5fa8bf6bf9d20ccb37ed46ec7027a9ac64b2a2a7 (diff)
parenta81a7fbc1a423b112158c2d8647ee80caba108ef (diff)
downloadgit-6a8989709efbd6d5187005497907264fde026ae9.zip
git-6a8989709efbd6d5187005497907264fde026ae9.tar.gz
git-6a8989709efbd6d5187005497907264fde026ae9.tar.bz2
Merge branch 'rs/commit-list-append'
There is no need for "commit_list_reverse()" function that only invites inefficient code. By René Scharfe * rs/commit-list-append: commit: remove commit_list_reverse() revision: append to list instead of insert and reverse sequencer: export commit_list_append()
Diffstat (limited to 'revision.c')
-rw-r--r--revision.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/revision.c b/revision.c
index e0e80f1..935e7a7 100644
--- a/revision.c
+++ b/revision.c
@@ -2075,6 +2075,7 @@ int prepare_revision_walk(struct rev_info *revs)
{
int nr = revs->pending.nr;
struct object_array_entry *e, *list;
+ struct commit_list **next = &revs->commits;
e = list = revs->pending.objects;
revs->pending.nr = 0;
@@ -2085,12 +2086,11 @@ int prepare_revision_walk(struct rev_info *revs)
if (commit) {
if (!(commit->object.flags & SEEN)) {
commit->object.flags |= SEEN;
- commit_list_insert(commit, &revs->commits);
+ next = commit_list_append(commit, next);
}
}
e++;
}
- commit_list_reverse(&revs->commits);
commit_list_sort_by_date(&revs->commits);
if (!revs->leak_pending)
free(list);