path: root/rev-parse.c
diff options
authorLinus Torvalds <>2006-01-25 22:00:37 (GMT)
committerJunio C Hamano <>2006-01-25 22:44:52 (GMT)
commitd8f6b342ae200b2eb72e2f81afea7fe0d41aec0b (patch)
treeda9a928a9bb8bdd0977a36a02d292cacedde2986 /rev-parse.c
parent92643a27cc2cc7ce55ba2afd6155f94b40e1aa89 (diff)
Make git-rev-list and git-rev-parse argument parsing stricter
If you pass it a filename without the "--" marker to separate it from revision information and flags, we now require that the file in question actually exists. This makes mis-typed revision information not be silently just considered a strange filename. With the "--" marker, you can continue to pass in filenames that do not actually exists - useful for querying what happened to a file that you no longer have in the repository. [ All scripts should use the "--" format regardless, to make things unambiguous. So this change should not affect any existing tools ] Signed-off-by: Linus Torvalds <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'rev-parse.c')
1 files changed, 3 insertions, 0 deletions
diff --git a/rev-parse.c b/rev-parse.c
index 0c951af..7abad35 100644
--- a/rev-parse.c
+++ b/rev-parse.c
@@ -154,6 +154,7 @@ int main(int argc, char **argv)
const char *prefix = setup_git_directory();
for (i = 1; i < argc; i++) {
+ struct stat st;
char *arg = argv[i];
char *dotdot;
@@ -293,6 +294,8 @@ int main(int argc, char **argv)
if (verify)
die("Needed a single revision");
+ if (lstat(arg, &st) < 0)
+ die("'%s': %s", arg, strerror(errno));
as_is = 1;