diff options
| author | Jeff King <peff@peff.net> | 2013-04-05 22:17:40 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2013-04-07 01:56:42 (GMT) |
| commit | 110bcdc3d0ea9f0042f24a4c0319dede36dfe7f9 (patch) | |
| tree | 0dde8570d9aca652608ec9a99be3a158ab9e136b /remote-curl.c | |
| parent | 426e70d4a11ce3b4f70636d57c6a0ab16ae08a00 (diff) | |
| download | git-110bcdc3d0ea9f0042f24a4c0319dede36dfe7f9.zip git-110bcdc3d0ea9f0042f24a4c0319dede36dfe7f9.tar.gz git-110bcdc3d0ea9f0042f24a4c0319dede36dfe7f9.tar.bz2 | |
remote-curl: let servers override http 404 advice
When we get an http 404 trying to get the initial list of
refs from the server, we try to be helpful and remind the
user that update-server-info may need to be run. This looks
like:
$ git clone https://github.com/non/existent
Cloning into 'existent'...
fatal: https://github.com/non/existent/info/refs?service=git-upload-pack not found: did you run git update-server-info on the server?
Suggesting update-server-info may be a good suggestion for
users who are in control of the server repo and who are
planning to set up dumb http. But for users of smart http,
and especially users who are not in control of the server
repo, the advice is useless and confusing.
The previous patch taught remote-curl to show custom advice
from the server when it is available. When we have shown
messages from the server, we can also drop our custom
advice; what the server has to say is likely to be more
accurate and helpful.
We not only drop the mention of update-server-info, but also
show only the main repo URL, not the full "info/refs" and
service parameter. These elements may be useful for
debugging a broken server configuration, but again, anything
the server has provided is likely to be more useful (and one
can still use GIT_CURL_VERBOSE to get much more complete
debugging information).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'remote-curl.c')
| -rw-r--r-- | remote-curl.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/remote-curl.c b/remote-curl.c index 4fea94f..083efdf 100644 --- a/remote-curl.c +++ b/remote-curl.c @@ -209,7 +209,8 @@ static struct discovery* discover_refs(const char *service, int for_push) case HTTP_OK: break; case HTTP_MISSING_TARGET: - show_http_message(&type, &buffer); + if (!show_http_message(&type, &buffer)) + die("repository '%s' not found", url); die("%s not found: did you run git update-server-info on the" " server?", refs_url); case HTTP_NOAUTH: |