diff options
| author | Patrick Steinhardt <ps@pks.im> | 2024-02-21 12:37:27 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-02-21 17:58:05 (GMT) |
| commit | e69e8ffef7369ca0d24c570d2657e41cf5e45936 (patch) | |
| tree | c1411b72ebf3c4d434267a4f2d8c815bf073c3d4 /refs/files-backend.c | |
| parent | de34f2651ecca00dffeb61934253345150a1cc32 (diff) | |
| download | git-e69e8ffef7369ca0d24c570d2657e41cf5e45936.zip git-e69e8ffef7369ca0d24c570d2657e41cf5e45936.tar.gz git-e69e8ffef7369ca0d24c570d2657e41cf5e45936.tar.bz2 | |
refs/files: sort reflogs returned by the reflog iterator
We use a directory iterator to return reflogs via the reflog iterator.
This iterator returns entries in the same order as readdir(3P) would and
will thus yield reflogs with no discernible order.
Set the new `DIR_ITERATOR_SORTED` flag that was introduced in the
preceding commit so that the order is deterministic. While the effect of
this can only been observed in a test tool, a subsequent commit will
start to expose this functionality to users via a new `git reflog list`
subcommand.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'refs/files-backend.c')
| -rw-r--r-- | refs/files-backend.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/refs/files-backend.c b/refs/files-backend.c index 75dcc21..2ffc631 100644 --- a/refs/files-backend.c +++ b/refs/files-backend.c @@ -2193,7 +2193,7 @@ static struct ref_iterator *reflog_iterator_begin(struct ref_store *ref_store, strbuf_addf(&sb, "%s/logs", gitdir); - diter = dir_iterator_begin(sb.buf, 0); + diter = dir_iterator_begin(sb.buf, DIR_ITERATOR_SORTED); if (!diter) { strbuf_release(&sb); return empty_ref_iterator_begin(); @@ -2202,7 +2202,7 @@ static struct ref_iterator *reflog_iterator_begin(struct ref_store *ref_store, CALLOC_ARRAY(iter, 1); ref_iterator = &iter->base; - base_ref_iterator_init(ref_iterator, &files_reflog_iterator_vtable, 0); + base_ref_iterator_init(ref_iterator, &files_reflog_iterator_vtable, 1); iter->dir_iterator = diter; iter->ref_store = ref_store; strbuf_release(&sb); |