summaryrefslogtreecommitdiff
path: root/ref-filter.c
diff options
context:
space:
mode:
authorOlga Telezhnaya <olyatelezhnaya@gmail.com>2018-02-21 06:59:01 (GMT)
committerJunio C Hamano <gitster@pobox.com>2018-02-21 17:34:07 (GMT)
commitedfb8ba06822375b08796b7b4354a94d98b05d13 (patch)
tree7941c243a512d20604a8203f85ffcadda36a4fbe /ref-filter.c
parent2bbc6e8a92e5bfe4f1db3836d7106aa0e9df9479 (diff)
downloadgit-edfb8ba06822375b08796b7b4354a94d98b05d13.zip
git-edfb8ba06822375b08796b7b4354a94d98b05d13.tar.gz
git-edfb8ba06822375b08796b7b4354a94d98b05d13.tar.bz2
ref-filter: get rid of goto
Get rid of goto command in ref-filter for better readability. Signed-off-by: Olga Telezhnaia <olyatelezhnaya@gmail.com> Mentored-by: Christian Couder <christian.couder@gmail.com> Mentored by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'ref-filter.c')
-rw-r--r--ref-filter.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/ref-filter.c b/ref-filter.c
index 2570870..be94766 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -1494,11 +1494,11 @@ static void populate_value(struct ref_array_item *ref)
for (i = 0; i < used_atom_cnt; i++) {
struct atom_value *v = &ref->value[i];
if (v->s == NULL)
- goto need_obj;
+ break;
}
- return;
+ if (used_atom_cnt <= i)
+ return;
- need_obj:
get_object(ref, &ref->objectname, 0, &obj);
/*