summaryrefslogtreecommitdiff
path: root/read-cache.c
diff options
context:
space:
mode:
authorTanay Abhra <tanayabh@gmail.com>2014-08-07 16:21:18 (GMT)
committerJunio C Hamano <gitster@pobox.com>2014-08-07 20:33:26 (GMT)
commitb27a5720996172fbb2cc809f88f4eea09b5bbc42 (patch)
treef9bea2c098bdc64016ffd22e3604ea84c8e7f33a /read-cache.c
parent6881f0ccb4365d1beb1673f740952064d204bd50 (diff)
downloadgit-b27a5720996172fbb2cc809f88f4eea09b5bbc42.zip
git-b27a5720996172fbb2cc809f88f4eea09b5bbc42.tar.gz
git-b27a5720996172fbb2cc809f88f4eea09b5bbc42.tar.bz2
read-cache.c: replace `git_config()` with `git_config_get_*()` family
Use `git_config_get_*()` family instead of `git_config()` to take advantage of the config-set API which provides a cleaner control flow. Use an intermediate value, as `version` can not be used directly in git_config_get_int() due to incompatible type. Signed-off-by: Tanay Abhra <tanayabh@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'read-cache.c')
-rw-r--r--read-cache.c14
1 files changed, 3 insertions, 11 deletions
diff --git a/read-cache.c b/read-cache.c
index 5d3c8bd..acb132d 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1238,24 +1238,16 @@ static struct cache_entry *refresh_cache_entry(struct cache_entry *ce,
#define INDEX_FORMAT_DEFAULT 3
-static int index_format_config(const char *var, const char *value, void *cb)
-{
- unsigned int *version = cb;
- if (!strcmp(var, "index.version")) {
- *version = git_config_int(var, value);
- return 0;
- }
- return 1;
-}
-
static unsigned int get_index_format_default(void)
{
char *envversion = getenv("GIT_INDEX_VERSION");
char *endp;
+ int value;
unsigned int version = INDEX_FORMAT_DEFAULT;
if (!envversion) {
- git_config(index_format_config, &version);
+ if (!git_config_get_int("index.version", &value))
+ version = value;
if (version < INDEX_FORMAT_LB || INDEX_FORMAT_UB < version) {
warning(_("index.version set, but the value is invalid.\n"
"Using version %i"), INDEX_FORMAT_DEFAULT);