summaryrefslogtreecommitdiff
path: root/merge-ort.c
diff options
context:
space:
mode:
authorElijah Newren <newren@gmail.com>2021-01-01 02:34:39 (GMT)
committerJunio C Hamano <gitster@pobox.com>2021-01-04 18:40:45 (GMT)
commit0ccfa4e5d8489abe7c5d3fe29b68e4fe0cae6fe1 (patch)
tree7ff5c7ba2b9910609f1ed191449fe75dcb7b4204 /merge-ort.c
parentc5a6f65527aa3b6f5d7cf25437a88d8727ab0646 (diff)
downloadgit-0ccfa4e5d8489abe7c5d3fe29b68e4fe0cae6fe1.zip
git-0ccfa4e5d8489abe7c5d3fe29b68e4fe0cae6fe1.tar.gz
git-0ccfa4e5d8489abe7c5d3fe29b68e4fe0cae6fe1.tar.bz2
merge-ort: handle D/F conflict where directory disappears due to merge
When one side has a directory at a given path and the other side of history has a file at the path, but the merge resolves the directory away (e.g. because no path within that directory was modified and the other side deleted it, or because renaming moved all the files elsewhere), then we don't actually have a conflict anymore. We just need to clear away any information related to the relevant directory, and then the subsequent process_entry() handling can handle the given path. Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'merge-ort.c')
-rw-r--r--merge-ort.c23
1 files changed, 22 insertions, 1 deletions
diff --git a/merge-ort.c b/merge-ort.c
index 414e7b7..dd90987 100644
--- a/merge-ort.c
+++ b/merge-ort.c
@@ -976,7 +976,28 @@ static void process_entry(struct merge_options *opt,
assert(ci->df_conflict);
}
- if (ci->df_conflict) {
+ if (ci->df_conflict && ci->merged.result.mode == 0) {
+ int i;
+
+ /*
+ * directory no longer in the way, but we do have a file we
+ * need to place here so we need to clean away the "directory
+ * merges to nothing" result.
+ */
+ ci->df_conflict = 0;
+ assert(ci->filemask != 0);
+ ci->merged.clean = 0;
+ ci->merged.is_null = 0;
+ /* and we want to zero out any directory-related entries */
+ ci->match_mask = (ci->match_mask & ~ci->dirmask);
+ ci->dirmask = 0;
+ for (i = MERGE_BASE; i <= MERGE_SIDE2; i++) {
+ if (ci->filemask & (1 << i))
+ continue;
+ ci->stages[i].mode = 0;
+ oidcpy(&ci->stages[i].oid, &null_oid);
+ }
+ } else if (ci->df_conflict && ci->merged.result.mode != 0) {
die("Not yet implemented.");
}