diff options
| author | Junio C Hamano <gitster@pobox.com> | 2012-12-22 07:26:16 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2012-12-22 07:55:10 (GMT) |
| commit | 021f2f4c1aed011c664844408325fe683a4046a8 (patch) | |
| tree | eb9774b7f51800a2e2e8171760d1d6f58eb653bc /log-tree.c | |
| parent | 68cb7b6f85aa032c33e49137364da9b76b1d95a1 (diff) | |
| download | git-021f2f4c1aed011c664844408325fe683a4046a8.zip git-021f2f4c1aed011c664844408325fe683a4046a8.tar.gz git-021f2f4c1aed011c664844408325fe683a4046a8.tar.bz2 | |
get_patch_filename(): simplify function signature
Most functions that emit to a strbuf take the strbuf as their first
parameter; make this function follow suit.
The serial number of the patch being emitted (nr) and suffix used
for patch filename (suffix) are both recorded in rev_info; drop
these separate parameters and pass the rev_info directly.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'log-tree.c')
| -rw-r--r-- | log-tree.c | 12 |
1 files changed, 8 insertions, 4 deletions
@@ -299,9 +299,12 @@ static unsigned int digits_in_number(unsigned int number) return result; } -void get_patch_filename(struct commit *commit, const char *subject, int nr, - const char *suffix, struct strbuf *buf) +void get_patch_filename(struct strbuf *buf, + struct commit *commit, const char *subject, + struct rev_info *info) { + const char *suffix = info->patch_suffix; + int nr = info->nr; int suffix_len = strlen(suffix) + 1; int start_len = buf->len; @@ -387,8 +390,9 @@ void log_write_email_headers(struct rev_info *opt, struct commit *commit, mime_boundary_leader, opt->mime_boundary); extra_headers = subject_buffer; - get_patch_filename(opt->numbered_files ? NULL : commit, NULL, - opt->nr, opt->patch_suffix, &filename); + get_patch_filename(&filename, + opt->numbered_files ? NULL : commit, NULL, + opt); snprintf(buffer, sizeof(buffer) - 1, "\n--%s%s\n" "Content-Type: text/x-patch;" |