summaryrefslogtreecommitdiff
path: root/git.c
diff options
context:
space:
mode:
authorKarthik Nayak <karthik.188@gmail.com>2015-03-06 11:18:08 (GMT)
committerJunio C Hamano <gitster@pobox.com>2015-03-07 03:42:00 (GMT)
commit6a536e2076f02a98e0d6403ff68f3acf717fa1c4 (patch)
tree5f41839de6e8728f22c86e90f9bfe2e3ae99e328 /git.c
parent9874fca7122563e28d699a911404fc49d2a24f1c (diff)
downloadgit-6a536e2076f02a98e0d6403ff68f3acf717fa1c4.zip
git-6a536e2076f02a98e0d6403ff68f3acf717fa1c4.tar.gz
git-6a536e2076f02a98e0d6403ff68f3acf717fa1c4.tar.bz2
git: treat "git -C '<path>'" as a no-op when <path> is empty
'git -C ""' unhelpfully dies with error "Cannot change to ''", whereas the shell treats `cd ""' as a no-op. Taking the shell's behavior as a precedent, teach git to treat `-C ""' as a no-op, as well. Helped-by: Junio C Hamano <gitster@pobox.com> Helped-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Karthik Nayak <karthik.188@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git.c')
-rw-r--r--git.c10
1 files changed, 6 insertions, 4 deletions
diff --git a/git.c b/git.c
index 6b5ae6a..fdea110 100644
--- a/git.c
+++ b/git.c
@@ -204,10 +204,12 @@ static int handle_options(const char ***argv, int *argc, int *envchanged)
fprintf(stderr, "No directory given for -C.\n" );
usage(git_usage_string);
}
- if (chdir((*argv)[1]))
- die_errno("Cannot change to '%s'", (*argv)[1]);
- if (envchanged)
- *envchanged = 1;
+ if ((*argv)[1][0]) {
+ if (chdir((*argv)[1]))
+ die_errno("Cannot change to '%s'", (*argv)[1]);
+ if (envchanged)
+ *envchanged = 1;
+ }
(*argv)++;
(*argc)--;
} else {