diff options
author | Torsten Bögershausen <tboegi@web.de> | 2019-03-19 17:13:46 (GMT) |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2019-03-20 00:48:53 (GMT) |
commit | ad006fe419efda47b0012347c5c2925f9a082101 (patch) | |
tree | 92e7b6a918a6060d967dbf0523ecc7249d32ac5c /git-svn.perl | |
parent | 32038fef00b02fb52f362d1d0cf1c25c6c382abb (diff) | |
download | git-ad006fe419efda47b0012347c5c2925f9a082101.zip git-ad006fe419efda47b0012347c5c2925f9a082101.tar.gz git-ad006fe419efda47b0012347c5c2925f9a082101.tar.bz2 |
trace2: NULL is not allowed for va_list
Some compilers don't allow NULL to be passed for a va_list,
and e.g. "gcc (Raspbian 6.3.0-18+rpi1+deb9u1) 6.3.0 20170516"
errors out like this:
trace2/tr2_tgt_event.c:193:18:
error: invalid operands to binary &&
(have ‘int’ and ‘va_list {aka __va_list}’)
if (fmt && *fmt && ap) {
^^
I couldn't find any hints that va_list and pointers can be mixed,
and no hints that they can't either. Morten Welinder comments:
"C99, Section 7.15, simply says that va_list "is an object type suitable for
holding information needed by the macros va_start, va_end, and
va_copy". So clearly not guaranteed to be mixable with pointers...
The portable solution is to use "va_list" everywhere in the callchain.
As a consequence, both trace2_region_enter_fl() and trace2_region_leave_fl()
now take a variable argument list.
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
Acked-by: Jeff Hostetler <jeffhost@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-svn.perl')
0 files changed, 0 insertions, 0 deletions