diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2010-09-30 13:43:02 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-09-30 19:20:33 (GMT) |
| commit | ff483897317b5379e189d6bd782270dd08c09966 (patch) | |
| tree | 500c5a88d51d420e0e6572fab8a1d8e7c0bac10d /git-send-email.perl | |
| parent | 0d290a46346f465a735bf50244d033e2257b0326 (diff) | |
| download | git-ff483897317b5379e189d6bd782270dd08c09966.zip git-ff483897317b5379e189d6bd782270dd08c09966.tar.gz git-ff483897317b5379e189d6bd782270dd08c09966.tar.bz2 | |
send-email: sanitize_address use $foo, not "$foo"
There's no reason to explicitly stringify a variable in Perl unless
it's an overloaded object and you want to call overload::StrVal,
otherwise it's just creating a new scalar redundantly.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.comReviewed-by: Avery Pennarun <apenwarr@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-send-email.perl')
| -rwxr-xr-x | git-send-email.perl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/git-send-email.perl b/git-send-email.perl index 1218bbe..1bf090a 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -864,7 +864,7 @@ sub sanitize_address { my ($recipient_name, $recipient_addr) = ($recipient =~ /^(.*?)\s*(<.*)/); if (not $recipient_name) { - return "$recipient"; + return $recipient; } # if recipient_name is already quoted, do nothing |