path: root/
diff options
authorShawn O. Pearce <>2007-08-21 06:22:53 (GMT)
committerShawn O. Pearce <>2007-08-21 06:22:53 (GMT)
commitce015c213fbef39140b6192db28110bc666dc6c8 (patch)
treed8f1ac62bf5e888da5307d6f604acafe4b7cc652 /
parent18a01a0da428c9e1034247e2b40c62e506b73580 (diff)
git-gui: Paper bag fix "Stage Hunk For Commit" in diff context menu
In a13ee29b975d3a9a012983309e842d942b2bbd44 I totally broke the "Stage Hunk For Commit" feature by making this menu item always appear in a disabled state, so it was never invokable. A "teaser feature", just sitting there taunting the poor user who has become used to having it available. The issue caused by a13ee was I added a test to look at the data in $file_states, but I didn't do that test correctly as it was always looking at a procedure local $file_states array, which is not defined, so the test was always true and we always disabled the menu entry. Instead we only want to disable the menu entry if the current file we are looking at has no file state information (git-gui is just a very confused little process) or it is an untracked file (and we cannot stage individual hunks). Signed-off-by: Shawn O. Pearce <>
Diffstat (limited to '')
1 files changed, 4 insertions, 3 deletions
diff --git a/ b/
index 2686c1b..d5517b9 100755
--- a/
+++ b/
@@ -2416,15 +2416,16 @@ $ctxm add separator
$ctxm add command -label {Options...} \
-command do_options
proc popup_diff_menu {ctxm x y X Y} {
- global current_diff_path
+ global current_diff_path file_states
set ::cursorX $x
set ::cursorY $y
if {$::ui_index eq $::current_diff_side} {
$ctxm entryconf $::ui_diff_applyhunk \
-state normal \
-label {Unstage Hunk From Commit}
- } elseif {![info exists file_states($current_diff_path)]
- || {_O} eq [lindex $file_states($::current_diff_path) 0]} {
+ } elseif {$current_diff_path eq {}
+ || ![info exists file_states($current_diff_path)]
+ || {_O} eq [lindex $file_states($current_diff_path) 0]} {
$ctxm entryconf $::ui_diff_applyhunk \
-state disabled \
-label {Stage Hunk For Commit}