diff options
| author | Jeff King <peff@peff.net> | 2015-10-05 03:45:26 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2015-10-05 18:06:49 (GMT) |
| commit | fdf729661a777d8bd598f40055d92b2df5601332 (patch) | |
| tree | f550af4a1bab89529aa73accc8e08a6a43b2f3a3 /git-compat-util.h | |
| parent | e2b021eb5b5ce2f4be3c10f1f8063981b1a53053 (diff) | |
| download | git-fdf729661a777d8bd598f40055d92b2df5601332.zip git-fdf729661a777d8bd598f40055d92b2df5601332.tar.gz git-fdf729661a777d8bd598f40055d92b2df5601332.tar.bz2 | |
probe_utf8_pathname_composition: use internal strbuf
When we are initializing a .git directory, we may call
probe_utf8_pathname_composition to detect utf8 mangling. We
pass in a path buffer for it to use, and it blindly
strcpy()s into it, not knowing whether the buffer is large
enough to hold the result or not.
In practice this isn't a big deal, because the buffer we
pass in already contains "$GIT_DIR/config", and we append
only a few extra bytes to it. But we can easily do the right
thing just by calling git_path_buf ourselves. Technically
this results in a different pathname (before we appended our
utf8 characters to the "config" path, and now they get their
own files in $GIT_DIR), but that should not matter for our
purposes.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-compat-util.h')
| -rw-r--r-- | git-compat-util.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/git-compat-util.h b/git-compat-util.h index 348b9dc..9a3e559 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -229,7 +229,7 @@ typedef unsigned long uintptr_t; #else #define precompose_str(in,i_nfd2nfc) #define precompose_argv(c,v) -#define probe_utf8_pathname_composition(a,b) +#define probe_utf8_pathname_composition() #endif #ifdef MKDIR_WO_TRAILING_SLASH |