path: root/fetch-pack.c
diff options
authorJeff King <>2019-03-20 08:16:14 (GMT)
committerJunio C Hamano <>2019-03-20 09:34:09 (GMT)
commit0f804b0bac39fb696ea74b8dd59549935ec9ca00 (patch)
tree394d187c972446e54d13da8f85873e9fbe9a3f81 /fetch-pack.c
parentc5c33504c906f6bf09fe00a1a32c6c4bdb76ed0f (diff)
fetch_pack(): drop unused parameters
We don't need the caller of fetch_pack() to pass in "dest", which is the remote URL. Since ba227857d2 (Reduce the number of connects when fetching, 2008-02-04), the caller is responsible for calling git_connect() itself, and our "dest" parameter is unused. That commit also started passing us the resulting "conn" child_process from git_connect(). But likewise, we do not need do anything with it. The descriptors in "fd" are enough for us, and the caller is responsible for cleaning up "conn". We can just drop both parameters. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'fetch-pack.c')
1 files changed, 1 insertions, 2 deletions
diff --git a/fetch-pack.c b/fetch-pack.c
index e69993b..8d67d4e 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -1615,9 +1615,8 @@ static int iterate_ref_map(void *cb_data, struct object_id *oid)
struct ref *fetch_pack(struct fetch_pack_args *args,
- int fd[], struct child_process *conn,
+ int fd[],
const struct ref *ref,
- const char *dest,
struct ref **sought, int nr_sought,
struct oid_array *shallow,
char **pack_lockfile,