path: root/fast-import.c
diff options
authorAlex Riesen <>2009-04-29 21:22:56 (GMT)
committerJunio C Hamano <>2009-04-30 01:37:41 (GMT)
commit691f1a28bf57618d8b44a193b1d28013c858aba6 (patch)
tree7d404656089320d486f658d3f4c061cd13dff556 /fast-import.c
parentfc71db39e0d75e8a403f36f3fecf4450886cd165 (diff)
replace direct calls to unlink(2) with unlink_or_warn
This helps to notice when something's going wrong, especially on systems which lock open files. I used the following criteria when selecting the code for replacement: - it was already printing a warning for the unlink failures - it is in a function which already printing something or is called from such a function - it is in a static function, returning void and the function is only called from a builtin main function (cmd_) - it is in a function which handles emergency exit (signal handlers) - it is in a function which is obvously cleaning up the lockfiles Signed-off-by: Alex Riesen <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'fast-import.c')
1 files changed, 2 insertions, 2 deletions
diff --git a/fast-import.c b/fast-import.c
index 8d959af..6a618e9 100644
--- a/fast-import.c
+++ b/fast-import.c
@@ -931,7 +931,7 @@ static void unkeep_all_packs(void)
struct packed_git *p = all_packs[k];
snprintf(name, sizeof(name), "%s/pack/pack-%s.keep",
get_object_directory(), sha1_to_hex(p->sha1));
- unlink(name);
+ unlink_or_warn(name);
@@ -981,7 +981,7 @@ static void end_packfile(void)
else {
- unlink(old_p->pack_name);
+ unlink_or_warn(old_p->pack_name);