summaryrefslogtreecommitdiff
path: root/contrib
diff options
context:
space:
mode:
authorSZEDER Gábor <szeder.dev@gmail.com>2017-03-23 15:29:21 (GMT)
committerJunio C Hamano <gitster@pobox.com>2017-03-23 18:18:22 (GMT)
commit400a7553c4e0f0cafa1bef5a1dd792b6cc10c450 (patch)
treebbd88c21538b34ecf8e6c339d747e996577f72b6 /contrib
parent824388d54b238b0d0cdc3f584dd27cb334df4ebc (diff)
downloadgit-400a7553c4e0f0cafa1bef5a1dd792b6cc10c450.zip
git-400a7553c4e0f0cafa1bef5a1dd792b6cc10c450.tar.gz
git-400a7553c4e0f0cafa1bef5a1dd792b6cc10c450.tar.bz2
completion: let 'for-each-ref' sort remote branches for 'checkout' DWIMery
When listing unique remote branches for 'git checkout's tracking DWIMery, __git_refs() runs the classic '... |sort |uniq -u' pattern to filter out duplicate remote branches. Let 'git for-each-ref' do the sorting, sparing the overhead of fork()+exec()ing 'sort' and a stage in the pipeline where potentially relatively large amount of data can be passed between two subsequent pipeline stages. This speeds up refs completion for 'git checkout' a bit when a lot of remote branches match the current word to be completed. Listing a single local and 100k remote branches, all packed, best of five: On Linux, before: $ time __git_complete_refs --track real 0m1.856s user 0m1.816s sys 0m0.060s After: real 0m1.550s user 0m1.512s sys 0m0.060s On Windows, before: real 0m3.128s user 0m2.155s sys 0m0.183s After: real 0m2.781s user 0m1.826s sys 0m0.136s Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib')
-rw-r--r--contrib/completion/git-completion.bash3
1 files changed, 2 insertions, 1 deletions
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 394dcec..d263128 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -423,8 +423,9 @@ __git_refs ()
# Try to find a remote branch that matches the completion word
# but only output if the branch name is unique
__git for-each-ref --format="%(refname:strip=3)" \
+ --sort="refname:strip=3" \
"refs/remotes/*/$match*" "refs/remotes/*/$match*/**" | \
- sort | uniq -u
+ uniq -u
fi
return
fi