diff options
| author | SZEDER Gábor <szeder.dev@gmail.com> | 2020-06-05 13:00:26 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-06-08 19:28:49 (GMT) |
| commit | 1df15f8dee5c637c9013d11d5b8e72e189a04f06 (patch) | |
| tree | 30f3bc9b9aa316db57a1ae1e723469ce0083362b /commit-slab-impl.h | |
| parent | 6141cdfdcbe9e3edf25467582c5f32658ae79f40 (diff) | |
| download | git-1df15f8dee5c637c9013d11d5b8e72e189a04f06.zip git-1df15f8dee5c637c9013d11d5b8e72e189a04f06.tar.gz git-1df15f8dee5c637c9013d11d5b8e72e189a04f06.tar.bz2 | |
commit-slab: add a function to deep free entries on the slab
clear_##slabname() frees only the memory allocated for a commit slab
itself, but entries in the commit slab might own additional memory
outside the slab that should be freed as well. We already have (at
least) one such commit slab, and this patch series is about to add one
more.
To free all additional memory owned by entries on the commit slab the
user of such a slab could iterate over all commits it knows about,
peek whether there is a valid entry associated with each commit, and
free the additional memory, if any. Or it could rely on intimate
knowledge about the internals of the commit slab implementation, and
could itself iterate directly through all entries in the slab, and
free the additional memory. Or it could just leak the additional
memory...
Introduce deep_clear_##slabname() to allow releasing memory owned by
commit slab entries by invoking the 'void free_fn(elemtype *ptr)'
function specified as parameter for each entry in the slab.
Use it in get_shallow_commits() in 'shallow.c' to replace an
open-coded iteration over a commit slab's entries.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'commit-slab-impl.h')
| -rw-r--r-- | commit-slab-impl.h | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/commit-slab-impl.h b/commit-slab-impl.h index 5c0eb91..557738d 100644 --- a/commit-slab-impl.h +++ b/commit-slab-impl.h @@ -38,6 +38,19 @@ scope void clear_ ##slabname(struct slabname *s) \ FREE_AND_NULL(s->slab); \ } \ \ +scope void deep_clear_ ##slabname(struct slabname *s, void (*free_fn)(elemtype *)) \ +{ \ + unsigned int i; \ + for (i = 0; i < s->slab_count; i++) { \ + unsigned int j; \ + if (!s->slab[i]) \ + continue; \ + for (j = 0; j < s->slab_size; j++) \ + free_fn(&s->slab[i][j * s->stride]); \ + } \ + clear_ ##slabname(s); \ +} \ + \ scope elemtype *slabname## _at_peek(struct slabname *s, \ const struct commit *c, \ int add_if_missing) \ |