summaryrefslogtreecommitdiff
path: root/cache.h
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2017-02-27 09:25:40 (GMT)
committerJunio C Hamano <gitster@pobox.com>2017-03-02 19:04:57 (GMT)
commit13228c30a6476456ee64eb7cefb7786d82fd2ca7 (patch)
treec829818e460604eb58cce62a44e38265b693db0e /cache.h
parent3b9e3c2cede15057af3ff8076c45ad5f33829436 (diff)
downloadgit-13228c30a6476456ee64eb7cefb7786d82fd2ca7.zip
git-13228c30a6476456ee64eb7cefb7786d82fd2ca7.tar.gz
git-13228c30a6476456ee64eb7cefb7786d82fd2ca7.tar.bz2
interpret_branch_name(): handle auto-namelen for @{-1}
The interpret_branch_name() function takes a ptr/len pair for the name, but you can pass "0" for "namelen", which will cause it to check the length with strlen(). However, before we do that auto-namelen magic, we call interpret_nth_prior_checkout(), which gets fed the bogus "0". This was broken by 8cd4249c4 (interpret_branch_name: always respect "namelen" parameter, 2014-01-15). Though to be fair to that commit, it was broken in the _opposite_ direction before, where we would always treat "name" as a string even if a length was passed. You can see the bug with "git log -g @{-1}". That code path always passes "0", and without this patch it cannot figure out which branch's reflog to show. We can fix it by a small reordering of the code. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'cache.h')
0 files changed, 0 insertions, 0 deletions