diff options
| author | Jonathan Nieder <jrnieder@gmail.com> | 2010-10-04 09:09:17 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-10-06 17:46:45 (GMT) |
| commit | 349362cc207c96bbf31f503db989f0289c13c05d (patch) | |
| tree | 507437c460f5a35b8377b6f821ab448ea1027610 /builtin | |
| parent | 9173912be36c4f967f42f176be767fc5ba3c4077 (diff) | |
| download | git-349362cc207c96bbf31f503db989f0289c13c05d.zip git-349362cc207c96bbf31f503db989f0289c13c05d.tar.gz git-349362cc207c96bbf31f503db989f0289c13c05d.tar.bz2 | |
xdiff: cast arguments for ctype functions to unsigned char
The ctype functions isspace(), isalnum(), et al take an integer
argument representing an unsigned character, or -1 for EOF. On
platforms with a signed char, it is unsafe to pass a char to them
without casting it to unsigned char first.
Most of git is already shielded against this by the ctype
implementation in git-compat-util.h, but xdiff, which uses libc
ctype.h, ought to be fixed.
Noticed-by: der Mouse <mouse@Rodents-Montreal.ORG>
Reported-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
0 files changed, 0 insertions, 0 deletions