summaryrefslogtreecommitdiff
path: root/builtin
diff options
context:
space:
mode:
authorRené Scharfe <l.s.r@web.de>2017-12-07 20:20:19 (GMT)
committerJunio C Hamano <gitster@pobox.com>2017-12-07 20:30:04 (GMT)
commit1b09073514085c51bbd2884122af60a45b24db5d (patch)
treecd30997a6732a6abb66d08707abc8fe8bfa4199e /builtin
parente97a5e765db06995c3b027a5d7dceb6b4f2cba02 (diff)
downloadgit-1b09073514085c51bbd2884122af60a45b24db5d.zip
git-1b09073514085c51bbd2884122af60a45b24db5d.tar.gz
git-1b09073514085c51bbd2884122af60a45b24db5d.tar.bz2
am: release strbuf after use in split_mail_mbox()
Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
-rw-r--r--builtin/am.c10
1 files changed, 7 insertions, 3 deletions
diff --git a/builtin/am.c b/builtin/am.c
index 1399c8d..2368853 100644
--- a/builtin/am.c
+++ b/builtin/am.c
@@ -702,6 +702,7 @@ static int split_mail_mbox(struct am_state *state, const char **paths, int keep_
{
struct child_process cp = CHILD_PROCESS_INIT;
struct strbuf last = STRBUF_INIT;
+ int ret;
cp.git_cmd = 1;
argv_array_push(&cp.args, "mailsplit");
@@ -713,13 +714,16 @@ static int split_mail_mbox(struct am_state *state, const char **paths, int keep_
argv_array_push(&cp.args, "--");
argv_array_pushv(&cp.args, paths);
- if (capture_command(&cp, &last, 8))
- return -1;
+ ret = capture_command(&cp, &last, 8);
+ if (ret)
+ goto exit;
state->cur = 1;
state->last = strtol(last.buf, NULL, 10);
- return 0;
+exit:
+ strbuf_release(&last);
+ return ret ? -1 : 0;
}
/**