diff options
| author | Christian Couder <chriscool@tuxfamily.org> | 2010-07-22 13:18:29 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-07-23 23:08:14 (GMT) |
| commit | 2c048a3038fd4d94e150fbc1dfd2242325ca7db6 (patch) | |
| tree | 18711aab4aa9fc19a4cff3c39bde1801b033e172 /builtin/revert.c | |
| parent | 971ecbd1f8d1468951274d01103f80dd7d32d110 (diff) | |
| download | git-2c048a3038fd4d94e150fbc1dfd2242325ca7db6.zip git-2c048a3038fd4d94e150fbc1dfd2242325ca7db6.tar.gz git-2c048a3038fd4d94e150fbc1dfd2242325ca7db6.tar.bz2 | |
revert: fix off by one read when searching the end of a commit subject
A test case is added but the problem can only be seen when running
the test case with --valgrind.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Acked-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/revert.c')
| -rw-r--r-- | builtin/revert.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/revert.c b/builtin/revert.c index 7d68ef7..c170715 100644 --- a/builtin/revert.c +++ b/builtin/revert.c @@ -127,7 +127,7 @@ static int get_message(const char *raw_message, struct commit_message *out) p++; if (*p) { p += 2; - for (eol = p + 1; *eol && *eol != '\n'; eol++) + for (eol = p; *eol && *eol != '\n'; eol++) ; /* do nothing */ } else eol = p; |