diff options
| author | Jeff King <peff@peff.net> | 2016-02-22 22:44:35 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-02-22 22:51:09 (GMT) |
| commit | 50a6c8efa2bbeddf46ca34c7765024108202e04b (patch) | |
| tree | 0c189695ed6ad8349527cb03d326ef3fb39707cf /builtin/fetch.c | |
| parent | 96ffc06f72f693d80f05059a1f0e5ca9007d5f1b (diff) | |
| download | git-50a6c8efa2bbeddf46ca34c7765024108202e04b.zip git-50a6c8efa2bbeddf46ca34c7765024108202e04b.tar.gz git-50a6c8efa2bbeddf46ca34c7765024108202e04b.tar.bz2 | |
use st_add and st_mult for allocation size computation
If our size computation overflows size_t, we may allocate a
much smaller buffer than we expected and overflow it. It's
probably impossible to trigger an overflow in most of these
sites in practice, but it is easy enough convert their
additions and multiplications into overflow-checking
variants. This may be fixing real bugs, and it makes
auditing the code easier.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/fetch.c')
| -rw-r--r-- | builtin/fetch.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/fetch.c b/builtin/fetch.c index 17f40e1..683f08e 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -1107,7 +1107,7 @@ static int fetch_one(struct remote *remote, int argc, const char **argv) if (argc > 0) { int j = 0; int i; - refs = xcalloc(argc + 1, sizeof(const char *)); + refs = xcalloc(st_add(argc, 1), sizeof(const char *)); for (i = 0; i < argc; i++) { if (!strcmp(argv[i], "tag")) { i++; |