diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2022-07-05 13:47:00 (GMT) |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-07-06 19:24:43 (GMT) |
commit | 06f5f8940c0335f2a5b0a7bbd086115f4659eaa8 (patch) | |
tree | 4fccdb7fd2c594dfcf0c42740d358cf8828d5886 /builtin/fetch.c | |
parent | 4f40f6cb7365889b262aa93871964f70c91a9ebc (diff) | |
download | git-06f5f8940c0335f2a5b0a7bbd086115f4659eaa8.zip git-06f5f8940c0335f2a5b0a7bbd086115f4659eaa8.tar.gz git-06f5f8940c0335f2a5b0a7bbd086115f4659eaa8.tar.bz2 |
cocci: generalize "unused" rule to cover more than "strbuf"
Generalize the newly added "unused.cocci" rule to find more than just
"struct strbuf", let's have it find the same unused patterns for
"struct string_list", as well as other code that uses
similar-looking *_{release,clear,free}() and {release,clear,free}_*()
functions.
We're intentionally loose in accepting e.g. a "strbuf_init(&sb)"
followed by a "string_list_clear(&sb, 0)". It's assumed that the
compiler will catch any such invalid code, i.e. that our
constructors/destructors don't take a "void *".
See [1] for example of code that would be covered by the
"get_worktrees()" part of this rule. We'd still need work that the
series is based on (we were passing "worktrees" to a function), but
could now do the change in [1] automatically.
1. https://lore.kernel.org/git/Yq6eJFUPPTv%2Fzc0o@coredump.intra.peff.net/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/fetch.c')
0 files changed, 0 insertions, 0 deletions