diff options
author | René Scharfe <l.s.r@web.de> | 2021-06-06 01:01:57 (GMT) |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-06-06 01:40:26 (GMT) |
commit | ebee5580ca7e4dba06405713de14507909615966 (patch) | |
tree | 6ab8278bbc876ac71f23e1e66151bbdcab1b108e /builtin/checkout--worker.c | |
parent | 87094fc2daa9613c2fad454dbb068a8f23ce8de8 (diff) | |
download | git-ebee5580ca7e4dba06405713de14507909615966.zip git-ebee5580ca7e4dba06405713de14507909615966.tar.gz git-ebee5580ca7e4dba06405713de14507909615966.tar.bz2 |
parallel-checkout: avoid dash local bug in tests
Dash bug https://bugs.launchpad.net/ubuntu/+source/dash/+bug/139097
lets the shell erroneously perform field splitting on the expansion of a
command substitution during declaration of a local variable. It causes
the parallel-checkout tests to fail e.g. when running them with
/bin/dash on MacOS 11.4, where they error out like this:
./t2080-parallel-checkout-basics.sh: 33: local: 0: bad variable name
That's because the output of wc -l contains leading spaces and the
returned number of lines is treated as another variable to declare, i.e.
as in "local workers= 0".
Work around it by enclosing the command substitution in quotes.
Helped-by: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Helped-by: SZEDER Gábor <szeder.dev@gmail.com>
Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/checkout--worker.c')
0 files changed, 0 insertions, 0 deletions